[webkit-reviews] review denied: [Bug 84939] Optimize ASCII to UTF16 conversion using SSE2. : [Attachment 139118] patch v.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 23:34:35 PDT 2012


James Robinson <jamesr at chromium.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 84939: Optimize ASCII to UTF16 conversion using SSE2.
https://bugs.webkit.org/show_bug.cgi?id=84939

Attachment 139118: patch v.2
https://bugs.webkit.org/attachment.cgi?id=139118&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139118&action=review


> Source/WebCore/platform/text/TextCodecASCIIFastPath.h:5
> + * Version: MPL 1.1/GPL 2.0/LGPL 2.1

we can't accept code under MPL or GPL into the WebKit project.	Please review
the following text (shown when you attach a bug via bugzilla's web interface,
although we should make it more prominent):

WebKit Contribution Terms:

Hello and thank you for contributing a patch. Here is our licensing policy and
terms for contributing code to the WebKit project.

If you are sending in a patch to existing WebKit code, you agree by clicking
below that your changes are licensed under the existing license terms of the
file you are modifying (i.e., BSD license or GNU Lesser General Public License
v.2.1, LGPL v. 2.1). Please also add your copyright (name and year) to the
relevant files for changes that are more than 10 lines of code.
If you are sending in a new file for inclusion in WebKit (no code copied from
another source), the preferred license is BSD, but LGPL 2.1 is an option as
well. Please include your copyright (name and year) and license preference (BSD
or LGPL 2.1). By clicking below you agree that your file is licensed under
either the BSD license or LGPL 2.1, as indicated in your file.
If you aren't the author of the patch, you agree to include the original
copyright notices and licensing terms with it, to the extent that they exist.
If there wasn't a copyright notice or license, please make a note of it.
Generally we can only take in patches that are BSD- or LGPL-licensed in order
to maintain license compatibility within the project.


More information about the webkit-reviews mailing list