[webkit-reviews] review granted: [Bug 85001] Clean up tests in preparation for ES5.2 global scope fix : [Attachment 139063] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 20:09:27 PDT 2012


Gavin Barraclough <barraclough at apple.com> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 85001: Clean up tests in preparation for ES5.2 global scope fix
https://bugs.webkit.org/show_bug.cgi?id=85001

Attachment 139063: Patch
https://bugs.webkit.org/attachment.cgi?id=139063&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This change is the right thing to do.  When we make changes to correctly
support ES5.2, we should add test cases to defend the new behavior.  If ES5.2
isn't compatible with the web, and we need to revert, then we can retain the
new tests but change them to defend the desired web-compatible behavior.


More information about the webkit-reviews mailing list