[webkit-reviews] review granted: [Bug 83983] REGRESSION(r96257): Deleting a large amount of text is very slow : [Attachment 139113] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 83983: REGRESSION(r96257): Deleting a large amount of text is very slow
https://bugs.webkit.org/show_bug.cgi?id=83983

Attachment 139113: Patch
https://bugs.webkit.org/attachment.cgi?id=139113&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139113&action=review


Thanks for the fix!

> Source/WebCore/ChangeLog:17
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the long description.

> Source/WebCore/dom/Position.cpp:180
> +	   return minOffsetForNode(m_anchorNode.get(), m_offset);

minOffset sounds like it's the minimum offset. Maybe capOffsetInNode? or
roundOffsetInNode?

> Source/WebCore/dom/Position.h:295
> +    for (Node* n = node->firstChild(); n && newOffset < offset; n =
n->nextSibling())

Please don't use abbreviations like n.

> Source/WebCore/dom/Position.h:307
> +    for (Node* n = node->firstChild(); n && currentOffset < offset; n =
n->nextSibling())

Ditto.