[webkit-reviews] review granted: [Bug 83944] Extract PerfTestFactory : [Attachment 137160] Renamed pattern_map to _pattern_map

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 17:07:14 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 83944: Extract PerfTestFactory
https://bugs.webkit.org/show_bug.cgi?id=83944

Attachment 137160: Renamed pattern_map to _pattern_map
https://bugs.webkit.org/attachment.cgi?id=137160&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=137160&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> +	      
tests.append(PerfTestFactory.create_perf_test(relative_path.replace('\\', '/'),
path))

I think you need to convert the \ to / before you call skips_perf_test on line
129, right?


More information about the webkit-reviews mailing list