[webkit-reviews] review granted: [Bug 85010] Improve compositing logging output : [Attachment 139078] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 15:23:50 PDT 2012


Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 85010: Improve compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=85010

Attachment 139078: Patch
https://bugs.webkit.org/attachment.cgi?id=139078&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139078&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:459
> +    LOG(Compositing, "%*p %dx%d %.3fMP (%s) %s\n", 12 + depth * 2, layer,
backing->compositedBounds().width(), backing->compositedBounds().height(),

maybe depth * 4 to be webkit stylish?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1456
> +	   return "transform-style: preserve-3d";

I think just "preserve-3d" is enough.


More information about the webkit-reviews mailing list