[webkit-reviews] review granted: [Bug 80540] [Chromium] Single buffered canvas layers with the threaded compositor : [Attachment 139029] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Justin Novosad
<junov at chromium.org>'s request for review:
Bug 80540: [Chromium] Single buffered canvas layers with the threaded
compositor
https://bugs.webkit.org/show_bug.cgi?id=80540

Attachment 139029: Patch
https://bugs.webkit.org/attachment.cgi?id=139029&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139029&action=review


R=me. I'll run through the tests locally and land this by hand (assuming that
deleting the ASSERT(0) is correct).

> Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:176
> +	       ASSERT(0);

I think this is bogus - if the front texture couldn't be reserved, then we want
to push a 0 texture here (so we don't generate a quad and attempt to draw).  Is
this just for local testing? I can remove before landing.