[webkit-reviews] review denied: [Bug 84978] Remove PropertyWrapper from AnimationBase : [Attachment 139042] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 26 13:02:20 PDT 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied review:
Bug 84978: Remove PropertyWrapper from AnimationBase
https://bugs.webkit.org/show_bug.cgi?id=84978
Attachment 139042: Patch
https://bugs.webkit.org/attachment.cgi?id=139042&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=139042&action=review
> Source/WebCore/ChangeLog:8
> + of property handlers. This patch remove the property handlers for a
> + separated class making AnimationBase simpler.
I'd use the term "move" rather than "remove".
> Source/WebCore/page/animation/AnimationPropertyHandler.h:41
> +class AnimationPropertyHandler {
I think PropertyAnimation would be a better name for this class, or maybe even
CSSPropertyAnimation.
More information about the webkit-reviews
mailing list