[webkit-reviews] review granted: [Bug 84946] Web Inspector: Implement the "Disable JavaScript" option in the settings dialog : [Attachment 139012] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 84946: Web Inspector: Implement the "Disable JavaScript" option in the
settings dialog
https://bugs.webkit.org/show_bug.cgi?id=84946

Attachment 139012: Patch
https://bugs.webkit.org/attachment.cgi?id=139012&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=139012&action=review


> Source/WebCore/inspector/Inspector.json:340
> +		   "name": "scriptExecutionStatus",

getScriptExecutionStatus ?

> Source/WebCore/inspector/InspectorPageAgent.cpp:727
> +	   settings->setScriptEnabled(!value);

Will this change be reflected in the browser settings?

> Source/WebCore/inspector/front-end/SettingsScreen.js:43
> +    p = this._appendSection(WebInspector.UIString("General"));

Please merge it with var p; above.