[webkit-reviews] review granted: [Bug 84018] [GTK][WK2] Implement API for generic permission requests : [Attachment 138114] Patch Proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 84018: [GTK][WK2] Implement API for generic permission requests
https://bugs.webkit.org/show_bug.cgi?id=84018

Attachment 138114: Patch Proposal
https://bugs.webkit.org/attachment.cgi?id=138114&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138114&action=review


Looks good. In the future, some requests show allow asynchronous handling. Some
probably won't allow that. The documentation in WebKitWebView should explain
the situation and we should add some API to make this discoverable.

> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:30
> + * for permission on certain type of operations, such as switching to

"to ask the user for permission on certain type" -> "to ask the user for
permission to do certain types"

> Source/WebKit2/UIProcess/API/gtk/WebKitPermissionRequest.cpp:31
> + * full screen mode or reporting the user's location through the

Nit: you use "full screen" here but "fullscreen" below.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:198
> +static gboolean webkitWebViewPermissionRequest(WebKitWebView*,
WebKitPermissionRequest* decision)
> +{
> +    webkit_permission_request_deny(decision);
> +    return TRUE;
> +}

Installing a default handler like this means that the request cannot be
answered asynchronously. Perhaps it's better to do this in the finalize method
for the concrete types.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:655
> +	* decide about a permission request, such as allowing the browser
> +	* switch to fullscreen mode, sharing its location or similar.

"allowing the browser to switch to fullscreen"

"or similar" -> "or similar operations."

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:658
> +	* A possible way to use this signal could be through a dialog to
> +	* allow the user decide what to do with the request:

"through a dialog to allow" -> "through a dialog allowing"