[webkit-reviews] review granted: [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests : [Attachment 138986] Updated patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 84446: [GTK] Build and run TestWebKitAPI WebKit2 unit tests
https://bugs.webkit.org/show_bug.cgi?id=84446

Attachment 138986: Updated patch
https://bugs.webkit.org/attachment.cgi?id=138986&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138986&action=review


Alright, looks good! Please don't forget to file new bugs for the skipped
tests.

> Tools/ChangeLog:18
> +	   * TestWebKitAPI/JavaScriptTest.cpp: Use
> +	   JavaScriptCore/JSContextRef.h instead of
> +	   JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
> +	   unconditionally.

Maybe I'm wrong but I think this issue should still be fixed. JavaScriptCore.h
shouldn't unconditionally include CF headers if it's meant to be used by
non-mac ports.