[webkit-reviews] review granted: [Bug 84948] [Qt][WK2] Tap highlight should have a delay not to interfere with panning : [Attachment 138990] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 84948: [Qt][WK2] Tap highlight should have a delay not to interfere with
panning
https://bugs.webkit.org/show_bug.cgi?id=84948

Attachment 138990: proposed patch
https://bugs.webkit.org/attachment.cgi?id=138990&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review


> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102
> +void QtTapGestureRecognizer::tapHighlightTimeout()

We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient

> Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39
> +const int tapHighlightThreshold = 80;

highlightPostponeTime would make more sense

> Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499
> +	   // Early return since this was a touch end event.

touch-end event