[webkit-reviews] review canceled: [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests : [Attachment 138743] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 06:17:14 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 84446: [GTK] Build and run TestWebKitAPI WebKit2 unit tests
https://bugs.webkit.org/show_bug.cgi?id=84446

Attachment 138743: Updated patch
https://bugs.webkit.org/attachment.cgi?id=138743&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Rebased to apply on current git master. Use g_idle_add instead of g_timeout_add
as suggested by Martin. And build a custom libmain instead of libgtestmain so
that all tests use TestsController class that initializes WTF threading to fix
bug #84868


More information about the webkit-reviews mailing list