[webkit-reviews] review granted: [Bug 84863] REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and ScriptProfileNode.idl should be T[] : [Attachment 138941] updatedPatch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 84863: REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and
ScriptProfileNode.idl should be T[]
https://bugs.webkit.org/show_bug.cgi?id=84863

Attachment 138941: updatedPatch
https://bugs.webkit.org/attachment.cgi?id=138941&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138941&action=review


Looks OK in terms of supporting T[]. There are a couple of "FIXME: support T[]
..." comments and "if (xxxx[])" conditions in CodeGenerator*.pm. We might want
to clean them up in a follow-up patch.

> Source/WebCore/bindings/scripts/CodeGenerator.pm:466
> +    return $1 if $type =~ /^([\w\d_\s]+)\[\]/;

Looks good.