[webkit-reviews] review granted: [Bug 84853] Share code used to animate discrete types between all animators : [Attachment 138797] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 84853: Share code used to animate discrete types between all animators
https://bugs.webkit.org/show_bug.cgi?id=84853

Attachment 138797: Patch
https://bugs.webkit.org/attachment.cgi?id=138797&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138797&action=review


Great cleanup, and you're adding a test. What's not to love? r=me

> Source/WebCore/svg/SVGAnimateElement.h:52
> +    virtual bool isAdditive() const;

We should add OVERRIDE here.