[webkit-reviews] review requested: [Bug 82751] http/tests/security/cross-frame-access-put.html is failing : [Attachment 138948] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 00:24:33 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 82751: http/tests/security/cross-frame-access-put.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82751

Attachment 138948: Patch
https://bugs.webkit.org/attachment.cgi?id=138948&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Proposing patch to update global expected result for
http/tests/security/cross-frame-access-put.html test. The value of
window.frameElement is now 'null' instead of 'undefined' when
shouldAllowAccessToNode() check fails, after bug 80205 fix.

- This fixes the test for EFL port which does not have platform-specific
expectation.
- GTK, Qt, Chromium ports have platform-specific expectations and have already
been updated.
- The test is skipped on wincairo, qt-mac, qt-arm, wk2, win and mac.


More information about the webkit-reviews mailing list