[webkit-reviews] review requested: [Bug 84863] REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and ScriptProfileNode.idl should be T[] : [Attachment 138941] updatedPatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 23:21:37 PDT 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 84863: REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and
ScriptProfileNode.idl should be T[]
https://bugs.webkit.org/show_bug.cgi?id=84863

Attachment 138941: updatedPatch
https://bugs.webkit.org/attachment.cgi?id=138941&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Updated patch.

I am not very good at perl-script so just wonder if below regExp is correct For
parsing T[].

> Source/WebCore/bindings/scripts/CodeGenerator.pm

> return $1 if $type =~ /^([\w\d_\s]+)\[\]/;


More information about the webkit-reviews mailing list