[webkit-reviews] review requested: [Bug 84589] [EFL][DRT] Implementation of showModalDialog needed : [Attachment 138936] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 84589: [EFL][DRT] Implementation of showModalDialog needed
https://bugs.webkit.org/show_bug.cgi?id=84589

Attachment 138936: Patch
https://bugs.webkit.org/attachment.cgi?id=138936&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
This patch fixes the following test cases which are not skipped:
 - http/tests/security/cross-frame-access-call.html
 - http/tests/security/cross-frame-access-get.html
 -
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidati
on-by-header.html
 -
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidati
on-by-method.html
 -
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.ht
ml
 - http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

It allows to remove several test cases from the skipped list as well.
Some more tests could be unskipped if we implement support for
LayoutTestController.abortModal() but I will handle this in a separate patch.