[webkit-reviews] review granted: [Bug 84926] [chromium] Cannot use guarded virtual methods in public API classes : [Attachment 138925] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 20:46:52 PDT 2012


James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 84926: [chromium] Cannot use guarded virtual methods in public API classes
https://bugs.webkit.org/show_bug.cgi?id=84926

Attachment 138925: Patch
https://bugs.webkit.org/attachment.cgi?id=138925&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138925&action=review


> Source/Platform/ChangeLog:3
> +	   [chromium] Cannot use guarded virtual methods in public API classes

this is not a description of a bug (public API classes shouldn't allow guarded
virtual methods, most likely) and it's not a good description of what this
patch is changing. can you update it (and the WebCore/ChangeLog entry too)?


More information about the webkit-reviews mailing list