[webkit-reviews] review granted: [Bug 84812] [chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches : [Attachment 138822] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 84812: [chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches
https://bugs.webkit.org/show_bug.cgi?id=84812

Attachment 138822: Patch
https://bugs.webkit.org/attachment.cgi?id=138822&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138822&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h:354
> +    bool m_betweenWillDrawAndDidDraw;

guard in #ifndef NDEBUG? i want to make it clear what bits of state are "real"
and what are for asserts - i think it'd be pretty weird if we started basing
"real" logic on this