[webkit-reviews] review denied: [Bug 84808] [chromium] Move ProgramBinding definitions to LayerRendererChromium and normalize naming : [Attachment 138698] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 84808: [chromium] Move ProgramBinding definitions to LayerRendererChromium
and normalize naming
https://bugs.webkit.org/show_bug.cgi?id=84808

Attachment 138698: Patch
https://bugs.webkit.org/attachment.cgi?id=138698&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138698&action=review


R♥ to all the program renames, inclusion removal, and program deduplication.

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:1012
> -	       binding.set(textureLayerProgramStretchFlip());
> +	       binding.set(textureTexRectProgramFlip());

...but you're changing the fragment shader here from
FragmentShaderRGBATexFlipAlpha to FragmentShaderRGBATexRectFlipAlpha (the io
surface one) for the non-io surface path.  Good thing our testing covers this.