[webkit-reviews] review granted: [Bug 84898] Biolab disaster crashes on ToT : [Attachment 138886] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 15:52:36 PDT 2012


Filip Pizlo <fpizlo at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 84898: Biolab disaster crashes on ToT
https://bugs.webkit.org/show_bug.cgi?id=84898

Attachment 138886: Patch
https://bugs.webkit.org/attachment.cgi?id=138886&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138886&action=review


r=me with the simplification

> Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp:115
> +	       InlineCallFrame& inlineCallFrame =
codeBlock()->inlineCallFrames()[i];
> +	       CodeBlock* codeBlock =
jsCast<FunctionExecutable*>(inlineCallFrame.executable.get())->baselineCodeBloc
kFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct);

baselineCodeBlockForInlineCallFrame(&codeBlock()->inlineCallFrames()[i])


More information about the webkit-reviews mailing list