[webkit-reviews] review granted: [Bug 80350] [Web Timing] Add a vendor-prefixed Performance Timeline API : [Attachment 133173] Patch

[bugzilla-daemon at webkit.org]

Tony Gentilcore <tonyg at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 80350: [Web Timing] Add a vendor-prefixed Performance Timeline API
https://bugs.webkit.org/show_bug.cgi?id=80350

Attachment 133173: Patch
https://bugs.webkit.org/attachment.cgi?id=133173&action=review

------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=133173&action=review


Looks really good. With the webkit-dev thread satisfied and the spec at last
call, I agree it is time to get this moving.

> Source/WebCore/ChangeLog:14
> +	   Test: fast/dom/Window/window-properties-performance.html

This doesn't really test it yet since it is disabled by default.

Perhaps the log could be more clear about that and the fact that this is
off-by-default.

> Source/WebCore/page/PerformanceEntry.h:57
> +    double m_duration;

Is it worth making this completely immutable (all data members const)?