[webkit-reviews] review granted: [Bug 84220] Implement object-literal constructor for Intent object : [Attachment 138827] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 10:06:35 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Greg Billock
<gbillock at google.com>'s request for review:
Bug 84220: Implement object-literal constructor for Intent object
https://bugs.webkit.org/show_bug.cgi?id=84220

Attachment 138827: Patch
https://bugs.webkit.org/attachment.cgi?id=138827&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138827&action=review


Looks OK. Thank you very much for the long discussion:)

> Source/WebCore/ChangeLog:8
> +	   This will hopefully be temporary, as we'll convert to just using
this
> +	   constructor, which can then use codegen.

Please explain why this patch is temporary. Recently there's been webkit-dev@
discussion on making ChangeLogs descriptive.


More information about the webkit-reviews mailing list