[webkit-reviews] review requested: [Bug 84601] [chromium] Add pause and resume support for accelerated css animations. : [Attachment 138820] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 84601: [chromium] Add pause and resume support for accelerated css
animations.
https://bugs.webkit.org/show_bug.cgi?id=84601

Attachment 138820: Patch
https://bugs.webkit.org/attachment.cgi?id=138820&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #4)
> (From update of attachment 138371 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=138371&action=review
>
> > Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:626
> > +void LayerChromium::suspendAnimations(double wallClockTime)
>
> why does this take a wall clock time? who's passing this in to us?
>
> if this is API we control, it should be using monotonicallyIncreasingTime. if
this is being fed in by WebCore, i'd prefer to handle the time rebasing before
it gets in to LayerChromium so we don't have to muck with it there
>
The time comes from WebCore. I've moved the rebasing out to
GraphicsLayerChromium.

> > Source/WebCore/platform/graphics/chromium/cc/CCActiveAnimation.cpp:137
> > +	 // Currently, we only push changes due to pausing and resuming
animations on the main thread.
>
> could you explain why it's OK to delete the code that used to live here?
The old code is never called. I've included its removal in several cl's but
none of them have landed yet.