[webkit-reviews] review canceled: [Bug 82468]=?UTF-8?Q?=20Deleting=20an=20array=20item=20causes=20it=20to=20appear=20as=20=60undefined=20=C3=97=201=60=20in=20the=20console=20?=: [Attachment 138815] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled sam <dsam2912 at gmail.com>'s
request for review:
Bug 82468: Deleting an array item causes it to appear as `undefined × 1` in the
console
https://bugs.webkit.org/show_bug.cgi?id=82468

Attachment 138815: Patch
https://bugs.webkit.org/attachment.cgi?id=138815&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138815&action=review


One small nit and it is good to go. You don't need to change localizedStrings
here. (resetting r?).

> Source/WebCore/inspector/front-end/ConsoleMessage.js:337
> +		   span.textContent = WebInspector.UIString("undefined");

You don't need to localize "undefined" - it is a JavaScript term. The reason it
was localized previously was "x %d" fragment.