[webkit-reviews] review requested: [Bug 84848] [cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator : [Attachment 138816] Removing composite operator override

[bugzilla-daemon at webkit.org]

Dominik Röttsches <dominik.rottsches at linux.intel.com> has asked  for review:
Bug 84848: [cairo] CairoGraphicsContext fillRect (with Color) overrides
composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848

Attachment 138816: Removing composite operator override
https://bugs.webkit.org/attachment.cgi?id=138816&action=review

------- Additional Comments from Dominik Röttsches
<dominik.rottsches at linux.intel.com>
For "historic" reasons there's a composite operator override in this function
which IMHO is very wrong. It's the root cause for breaking
svg/filters/feDropShadow.svg. Instead of the green drop shadow, a green
rectangle gets painted due to the operator override.

Fixing this one might be a bit tricky because of the rebaselining consequences.
If this gets landed, I think a number of cases need rebaselining. On EFL, I got
about 400 new failures with this one - I am now running the GTK tests.
So, first I would like to get an opinion from Martin Robinson.