[webkit-reviews] review denied: [Bug 82468]=?UTF-8?Q?=20Deleting=20an=20array=20item=20causes=20it=20to=20appear=20as=20=60undefined=20=C3=97=201=60=20in=20the=20console=20?=: [Attachment 138780] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 82468: Deleting an array item causes it to appear as `undefined × 1` in the
console
https://bugs.webkit.org/show_bug.cgi?id=82468

Attachment 138780: Patch
https://bugs.webkit.org/attachment.cgi?id=138780&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138780&action=review


> Source/WebCore/inspector/front-end/ConsoleMessage.js:341
> +	       if (!element || element.textContent === "undefined")

This change does not address the bug. You should instead modify appendUndefined
to not render "x 1" in case it is actually "1". The code was not handling the
undefined as the first value. This also needs a test (see
LayoutTests/inspector/console/console-format.html).