[webkit-reviews] review granted: [Bug 83568] [SVG] Nothing should be stroked when the stroke-width is 0 : [Attachment 138791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 06:11:31 PDT 2012


Nikolas Zimmermann <zimmermann at kde.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 83568: [SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Attachment 138791: Patch
https://bugs.webkit.org/attachment.cgi?id=138791&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138791&action=review


r=me, but please make sure this builds after you landed it, as there are no EWS
results available.

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:276
> +    if (!this->style()->svgStyle()->hasVisibleStroke())

Can't you used the passed in RenderStyle* here? I think you can.


More information about the webkit-reviews mailing list