[webkit-reviews] review denied: [Bug 83568] [SVG] Nothing should be stroked when the stroke-width is 0 : [Attachment 136472] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 83568: [SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Attachment 136472: Patch
https://bugs.webkit.org/attachment.cgi?id=136472&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136472&action=review


Thanks for tackling this, some comments leading to r-:

> Source/WebCore/rendering/svg/RenderSVGRect.cpp:123
> +    if (style()->svgStyle()->strokeWidth().isZero())
> +	   return;

How about adding "hasVisibleStroke" to SVGRenderStyle, which returns
"hasStroke() && !strokeWidth().isZero()".
Then this could turn into: if (!style()->svgStyle()->hasVisibleStroke())
return;

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:104
> +    if (!style()->svgStyle()->strokeWidth().isZero())

Ditto.

> Source/WebCore/rendering/svg/RenderSVGShape.cpp:276
> +    if (this->style()->svgStyle()->strokeWidth().isZero())

Ditto, not listing further occurrences of this.

> LayoutTests/ChangeLog:7
> +

You should also mark this as needs rebaseline for chromium.
Look for the SVG Tests section in platform/chromium/test_expectations.txt, and
add BUGWK83568 : svg/custom/path-zero-strokewidth.svg = IMAGE, same for the
other failure.