[webkit-reviews] review granted: [Bug 84820] [BlackBerry] [DRT] Some HTTP tests can't access relative css and/or javascript : [Attachment 138757] Git patch for bug 84820

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 84820: [BlackBerry] [DRT] Some HTTP tests can't access relative css and/or
javascript
https://bugs.webkit.org/show_bug.cgi?id=84820

Attachment 138757: Git patch for bug 84820
https://bugs.webkit.org/attachment.cgi?id=138757&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138757&action=review


> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:345
> +    return test.lower().substring(0, strlen(httpTestSyntax)) ==
httpTestSyntax
> +	       && test.lower().substring(strlen(httpTestSyntax),
strlen(localTestSyntax)) != localTestSyntax;

You could cache test.lower(), and the results of the strlen() calls in local
variables. Though as this is a DRT patch, I'll r+ it nevertheless, feel free to
make the changes, and reupload a patch or set cq+ on this one.