[webkit-reviews] review denied: [Bug 63941] Compilation bug - gcc 4.6.0 and c++0x : [Attachment 138677] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Michelangelo De Simone
<michelangelo at webkit.org>'s request for review:
Bug 63941: Compilation bug - gcc 4.6.0 and c++0x
https://bugs.webkit.org/show_bug.cgi?id=63941

Attachment 138677: Patch
https://bugs.webkit.org/attachment.cgi?id=138677&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138677&action=review


> Tools/qmake/mkspecs/features/unix/default_pre.prf:25
> +haveQt(4):linux-g++*:if (isEmpty(QT_GCC_MAJOR_VERSION) ||
isEmpty(QT_GCC_MINOR_VERSION)) {

This is not valid qmake syntax i believe, please write as:

haveQt(4):qpa {
    # Qt doesn't expose these constants if built with QPA enabled.
    # See https://bugs.webkit.org/show_bug.cgi?id=63941 for details.
    # FIXME: This is a temporary workaround for QTBUG-24974. 
    isEmpty(QT_GCC_MAJOR_VERSION)|isEmpty(QT_GCC_MINOR_VERSION) {
       stuff
    }
}