[webkit-reviews] review granted: [Bug 84825] New Notification constructor does not take security origin permissions into account : [Attachment 138738] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 22:27:13 PDT 2012


Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 84825: New Notification constructor does not take security origin
permissions into account
https://bugs.webkit.org/show_bug.cgi?id=84825

Attachment 138738: Patch
https://bugs.webkit.org/attachment.cgi?id=138738&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138738&action=review


> Source/WebCore/ChangeLog:18
> +	   (WebCore::Notification::dispatchErrorEvent): The default constructor
of ErrorEvent doesn't
> +	   create the proper event object. Create it using Event::create().

Is there a test showing that this was wrong?


More information about the webkit-reviews mailing list