[webkit-reviews] review denied: [Bug 84763] GC Activity Callback timer should be based on how much has been allocated since the last collection : [Attachment 138708] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 84763: GC Activity Callback timer should be based on how much has been
allocated since the last collection
https://bugs.webkit.org/show_bug.cgi?id=84763

Attachment 138708: Patch
https://bugs.webkit.org/attachment.cgi?id=138708&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138708&action=review


> Source/JavaScriptCore/runtime/GCActivityCallbackCF.cpp:58
> +const double timerSlop = 2.0; // Fudge factor to avoid performance cost
resetting timer.

Typo: missing "of" before "resetting".

> Source/JavaScriptCore/runtime/GCActivityCallbackCF.cpp:119
> +    double gcTimeSlice = std::max((static_cast<double>(bytes) / MB) *
gcTimeSlicePerMB, maxGCTimeSlice);

Needs to be min().