[webkit-reviews] review granted: [Bug 84682] [chromium-android] Dump Image in RGBA order with a checksum. : [Attachment 138576] patch v1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 84682: [chromium-android] Dump Image in RGBA order with a checksum.
https://bugs.webkit.org/show_bug.cgi?id=84682

Attachment 138576: patch v1
https://bugs.webkit.org/attachment.cgi?id=138576&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138576&action=review


This change is acceptable.

However
 - introduce webkit_support::EncodeRGBAPNGWithChecksum(), and
 - Make re-ordered bytes on the fly and pour it to MD5 digester
would be better for performance.

> Tools/DumpRenderTree/chromium/TestShell.cpp:674
> +    WTF::MD5 digester;
> +    WTF::Vector<uint8_t, 16> digestValue;

You don't need to add WTF::.

> Tools/DumpRenderTree/chromium/TestShell.cpp:685
> +    WTF::Vector<SkPMColor> pixelsInBGRAOrder;

ditto.

> Tools/DumpRenderTree/chromium/TestShell.cpp:688
> +	   SkPMColor* srcRow =
reinterpret_cast<SkPMColor*>(sourceBitmap.getAddr32(0, y));

nit: The variable name should be sourceRow for consistency.