[webkit-reviews] review denied: [Bug 83889] Crash in WebKit!WebCore::RenderBoxModelObject::paddingLeft+0x5c. : [Attachment 138412] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 83889: Crash in WebKit!WebCore::RenderBoxModelObject::paddingLeft+0x5c.
https://bugs.webkit.org/show_bug.cgi?id=83889

Attachment 138412: Patch
https://bugs.webkit.org/attachment.cgi?id=138412&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138412&action=review


r- on the premises that it should be tested.

> Source/WebCore/ChangeLog:9
> +	   RenderScrllbarPart instances, set owningRenderer(creating)/0

typo: RenderScrollbarPart.

> Source/WebCore/ChangeLog:14
> +	   No new tests.

OK, normally you would explain here why you couldn't make a DRT test case out
of the posted one (timing dependent or whatever the explination). Not providing
at test case is frown upon and most reviewers will just r- your patch based on
that.

Now, it's your lucky day as it turns out that cluster fuzz has a reduced test
case for that. I will post it.