[webkit-reviews] review granted: [Bug 83298] getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name : [Attachment 138664] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 16:05:34 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Kulanthaivel Palanichamy
<kulanthaivel at codeaurora.org>'s request for review:
Bug 83298: getMatchedCSSRules() should return null when the second argument is
an unrecognized pseudo-element name
https://bugs.webkit.org/show_bug.cgi?id=83298

Attachment 138664: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=138664&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Not sure we should commit more patches for an API we're planning to kill. That
said, this code is all isolated in code that will naturally go away when we
kill the API. So, in the meantime, may as well fix this on the off-chance that
we can't kill it.

It looks like this patch doesn't applies cleanly to DOMWindow.cpp. Please sync
and upload a new patch. Make sure it passes on the EWS bots before committing.


More information about the webkit-reviews mailing list