[webkit-reviews] review denied: [Bug 84762] webkit-patch rebaseline-test is retrieving stale expectations : [Attachment 138655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 15:40:34 PDT 2012


Ojan Vafai <ojan at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 84762: webkit-patch rebaseline-test is retrieving stale expectations
https://bugs.webkit.org/show_bug.cgi?id=84762

Attachment 138655: Patch
https://bugs.webkit.org/attachment.cgi?id=138655&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138655&action=review


> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:143
> +	   # correct results. Also, this fetch_from_zip test is really sleazy
because it
> +	   # is bypassing all of the unit tests ...
> +	   fetch_from_zip = self._tool.__class__.__name__ != 'MockTool'
> +	   if fetch_from_zip:

Can't we just update the tests with whatever the new output is? I don't think
we should be checking things like this in even temporarily. Some percentage of
code rot like this tends to stick around a lot longer than expected.


More information about the webkit-reviews mailing list