[webkit-reviews] review denied: [Bug 84787] WebGLRenderingContext methods should throw TypeError for not enough arguments : [Attachment 138662] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 84787: WebGLRenderingContext methods should throw TypeError for not enough
arguments
https://bugs.webkit.org/show_bug.cgi?id=84787

Attachment 138662: Patch
https://bugs.webkit.org/attachment.cgi?id=138662&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138662&action=review


The change seems positive overall but some cleanups are needed. Please also
work with zmo to incorporate this test into the WebGL conformance test suite.

> Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:146
> +	   return throwError(exec, createTypeError(exec, "Not enough
arguments"));

Please refactor this so that the string isn't duplicated throughout this file.

> Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:220
> +	   return throwError("Not enough arguments");

Same comment about refactoring here.