[webkit-reviews] review granted: [Bug 84779] Replace vague informative statement with the list of builders where the test isn't listed : [Attachment 138645] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 14:53:06 PDT 2012


Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 84779: Replace vague informative statement with the list of builders where
the test isn't listed
https://bugs.webkit.org/show_bug.cgi?id=84779

Attachment 138645: Patch
https://bugs.webkit.org/attachment.cgi?id=138645&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I like the idea of making the warning more informative, but I feat that listing
the builders is just going to be noisy and is unnecessary. At any rate, the
code looks fine, so it's your call.


More information about the webkit-reviews mailing list