[webkit-reviews] review canceled: [Bug 84413] Use Vector<Attribute> directly instead of encapsulating it in AttributeVector : [Attachment 138594] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 13:41:58 PDT 2012


Csaba Osztrogonac <ossy at webkit.org> has canceled  review:
Bug 84413: Use Vector<Attribute> directly instead of encapsulating it in
AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413

Attachment 138594: Patch
https://bugs.webkit.org/attachment.cgi?id=138594&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138594&action=review


> Source/WebCore/dom/ElementAttributeData.h:41
> +    ASSERT(attributes);

Reopen, because it broke the debug build:
../../../../Source/WebCore/dom/ElementAttributeData.h: In function
‘WebCore::Attribute* WebCore::findAttributeInVector(const
WTF::Vector<WebCore::Attribute, 0ul>&, const WebCore::QualifiedName&)’:
../../../../Source/WebCore/dom/ElementAttributeData.h:41: error: no match for
‘operator!’ in ‘!attributes’
../../../../Source/WebCore/dom/ElementAttributeData.h:41: note: candidates are:
operator!(bool) <built-in>


More information about the webkit-reviews mailing list