[webkit-reviews] review granted: [Bug 84413] Use Vector<Attribute> directly instead of encapsulating it in AttributeVector : [Attachment 138594] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 84413: Use Vector<Attribute> directly instead of encapsulating it in
AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413

Attachment 138594: Patch
https://bugs.webkit.org/attachment.cgi?id=138594&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138594&action=review


r=me with these fixes:

> Source/WebCore/dom/ElementAttributeData.h:39
> +inline Attribute* getAttributeFromVector(const Vector<Attribute>*
attributes, const QualifiedName& name)

- getAttributeFromVector doesn't sound very WebKit. findAttributeInVector would
be slightly better.
- The 'attributes' argument could be a const Vector<Attribute>&, that would
remove the need for the ASSERT.
- Also no need for the inline keyword.