[webkit-reviews] review requested: [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well : [Attachment 138573] Patch_With_Traits

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 08:59:58 PDT 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 84540: JS binding code generator doesn't handle "attribute unsigned long[]"
well
https://bugs.webkit.org/show_bug.cgi?id=84540

Attachment 138573: Patch_With_Traits
https://bugs.webkit.org/attachment.cgi?id=138573&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Attaching patch with using traits. I have tested compilation works now for

readonly attribute sequence<unsigned int> fastMallocStatistics;

In future we can add traits for other types as required like 

template<> struct traits<boolean> {
static inline v8::Handle<v8::Value> arrayV8Value(const unsigned int& value,
v8::Isolate*)
{
    return v8Boolean(value);
}
};


More information about the webkit-reviews mailing list