[webkit-reviews] review granted: [Bug 72796] [SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly : [Attachment 138571] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 72796: [SVG] getBBox on a <g> within symbol returns 0 but with defs it
works correctly
https://bugs.webkit.org/show_bug.cgi?id=72796

Attachment 138571: Patch
https://bugs.webkit.org/attachment.cgi?id=138571&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138571&action=review


r=me. With one change.

> Source/WebCore/ChangeLog:13
> +	   Create RenderSVGHiddenContainer for each <symbol>, which allows
creation of child renderers too. This fixes
> +	   both bugs since the bbox can be calculated at all times now and
gradients in <symbol> are always created.
> +	   This does allocate more memory but in general <symbol> is not used a
lot and they tend to be small subtrees.

Can you add Leo as original author please? "Patch by Leo Yang". Thanks.