[webkit-reviews] review denied: [Bug 84542] [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium : [Attachment 138513] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 08:43:36 PDT 2012


David Levin <levin at chromium.org> has denied Li Yin <li.yin at intel.com>'s request
for review:
Bug 84542: [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker)
is repeatedly called in chromium
https://bugs.webkit.org/show_bug.cgi?id=84542

Attachment 138513: Patch
https://bugs.webkit.org/attachment.cgi?id=138513&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138513&action=review


> Source/WebCore/ChangeLog:13
> +	   No new tests because this patch just deletes a repeated code, it can
reduce code workload and can't impact any feature.

This may impact features if the target type is set incorrectly and may result
in a change in behavior so it would be good to know the test that would expose
if there were this problem.


More information about the webkit-reviews mailing list