[webkit-reviews] review granted: [Bug 84325] [GTK] Build and run TestWebKitAPI unit tests : [Attachment 137912] Updated patch to try to fix the build

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 84325: [GTK] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=84325

Attachment 137912: Updated patch to try to fix the build
https://bugs.webkit.org/attachment.cgi?id=137912&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=137912&action=review


r=me but please address the following questions before landing:

> ChangeLog:9
> +	   * GNUmakefile.am: Include makefiles to build gtest and
> +	   TestWebKitAPI. Add BUILDING_WEBKIT2__ macro to compilation when

What about -DWTF_ENABLE_WEBKIT2 like Martin suggested?

> Tools/Scripts/run-gtk-tests:255
> +    def _run_test_google(self, test):

can this be renamed to _run_test_gtester or _run_gtester?