[webkit-reviews] review granted: [Bug 83973] [GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html : [Attachment 138311] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 83973: [GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html
https://bugs.webkit.org/show_bug.cgi?id=83973

Attachment 138311: Patch
https://bugs.webkit.org/attachment.cgi?id=138311&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138311&action=review


r=me but please consider this question before landing:

>> Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:45
>> +	    // JPEG doesn't support alpha channel. The <canvas> spec states
that toDataURL() must encode a Porter-Duff
> 
> Patch looks fine to me.
> 
> nit: CAIRO_FORMAT_ARGB32 is a given, right?  We could just assert if we're
concerned about it.
> 
> if (type == "jpeg") {
>   ASSERT(cairo_image_surface_get_format(surface) == CAIRO_FORMAT_ARGB32);
>      ...

Yes I think it'd be ok to proceed as Noel advises. Carlos?