[webkit-reviews] review granted: [Bug 82598] [GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API : [Attachment 135292] Updated patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 82598: [GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82598

Attachment 135292: Updated patch
https://bugs.webkit.org/attachment.cgi?id=135292&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135292&action=review


LGTM

> Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:36
> +void setCookieStoragePrivateBrowsingEnabled(bool enabled)
> +{
> +    notImplemented();

Would it make sense to start/stop observing cookies there? depending on the
enabled value.
I can't find this function used in WebKit2 btw, is it part of some
DerivedSources or was it removed from the other ports?