[webkit-reviews] review granted: [Bug 84680] Calendar Picker: Open a calendar picker by keyboard operation : [Attachment 138516] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 84680: Calendar Picker: Open a calendar picker by keyboard operation
https://bugs.webkit.org/show_bug.cgi?id=84680

Attachment 138516: Patch
https://bugs.webkit.org/attachment.cgi?id=138516&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138516&action=review


>>> Source/WebCore/html/BaseDateAndTimeInputType.cpp:144
>>> +	     handleWheelEventForSpinButton(event);
>> 
>> Is this needed to this patch?
> 
> This change is for consistency.  No spin button, no event handling for spin
button.
> 
> I should have mentioned this behavior change in ChangeLog.

Thanks for the clarification. Let's describe it in ChangeLog.