[webkit-reviews] review denied: [Bug 35999] Cmd-E should replace the current search term with the current selection : [Attachment 138501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 04:16:36 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 35999: Cmd-E should replace the current search term with the current
selection
https://bugs.webkit.org/show_bug.cgi?id=35999

Attachment 138501: Patch
https://bugs.webkit.org/attachment.cgi?id=138501&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138501&action=review


> Source/WebCore/ChangeLog:3
> +	   Web Inspector: Cmd-E should replace the current search term with the
current selection

I don't see this implemented in the patch.

> Source/WebCore/ChangeLog:6
> +	   Added the behavior for selected text to be made as auto search text

I don't think this is expected. At least browsers don't do that with the
generic search by default.


More information about the webkit-reviews mailing list