[webkit-reviews] review denied: [Bug 84542] [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium : [Attachment 138265] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 23:29:44 PDT 2012


David Levin <levin at chromium.org> has denied Li Yin <li.yin at intel.com>'s request
for review:
Bug 84542: [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker)
is repeatedly called in chromium
https://bugs.webkit.org/show_bug.cgi?id=84542

Attachment 138265: Patch
https://bugs.webkit.org/attachment.cgi?id=138265&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138265&action=review


> Source/WebCore/ChangeLog:12
> +	   No new tests. The current test has covered it already.

Which test?

> Source/WebCore/workers/Worker.cpp:75
>  #endif

Should we add an assert here to verify the target type?


More information about the webkit-reviews mailing list